Commit 6d3ad7e0 by Edward Thomson

Add `ENABLE_SYNCHRONIZED_OBJECT_CREATION` option

Allow users to enable `SYNCHRONIZED_OBJECT_CREATION` with a setting.
parent fc27fe21
...@@ -179,6 +179,7 @@ typedef enum { ...@@ -179,6 +179,7 @@ typedef enum {
GIT_OPT_SET_SSL_CIPHERS, GIT_OPT_SET_SSL_CIPHERS,
GIT_OPT_GET_USER_AGENT, GIT_OPT_GET_USER_AGENT,
GIT_OPT_ENABLE_OFS_DELTA, GIT_OPT_ENABLE_OFS_DELTA,
GIT_OPT_ENABLE_SYNCHRONIZED_OBJECT_CREATION,
} git_libgit2_opt_t; } git_libgit2_opt_t;
/** /**
...@@ -316,6 +317,13 @@ typedef enum { ...@@ -316,6 +317,13 @@ typedef enum {
* > Packfiles containing offset deltas can still be read. * > Packfiles containing offset deltas can still be read.
* > This defaults to enabled. * > This defaults to enabled.
* *
* * opts(GIT_OPT_ENABLE_SYNCHRONIZED_OBJECT_CREATION, int enabled)
*
* > Enable synchronized writes of new objects using `fsync`
* > (or the platform equivalent) to ensure that new object data
* > is written to permanent storage, not simply cached. This
* > defaults to disabled.
*
* @param option Option key * @param option Option key
* @param ... value to set the option * @param ... value to set the option
* @return 0 on success, <0 on failure * @return 0 on success, <0 on failure
......
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
#include "tag.h" #include "tag.h"
bool git_object__strict_input_validation = true; bool git_object__strict_input_validation = true;
bool git_object__synchronized_writing = false;
typedef struct { typedef struct {
const char *str; /* type name string */ const char *str; /* type name string */
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include "repository.h" #include "repository.h"
extern bool git_object__strict_input_validation; extern bool git_object__strict_input_validation;
extern bool git_object__synchronized_writing;
/** Base git object for inheritance */ /** Base git object for inheritance */
struct git_object { struct git_object {
......
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
#include "odb.h" #include "odb.h"
#include "delta.h" #include "delta.h"
#include "filebuf.h" #include "filebuf.h"
#include "object.h"
#include "git2/odb_backend.h" #include "git2/odb_backend.h"
#include "git2/types.h" #include "git2/types.h"
...@@ -843,7 +844,7 @@ static int filebuf_flags(loose_backend *backend) ...@@ -843,7 +844,7 @@ static int filebuf_flags(loose_backend *backend)
int flags = GIT_FILEBUF_TEMPORARY | int flags = GIT_FILEBUF_TEMPORARY |
(backend->object_zlib_level << GIT_FILEBUF_DEFLATE_SHIFT); (backend->object_zlib_level << GIT_FILEBUF_DEFLATE_SHIFT);
if (backend->fsync_object_files) if (backend->fsync_object_files || git_object__synchronized_writing)
flags |= GIT_FILEBUF_FSYNC; flags |= GIT_FILEBUF_FSYNC;
return flags; return flags;
......
...@@ -227,6 +227,10 @@ int git_libgit2_opts(int key, ...) ...@@ -227,6 +227,10 @@ int git_libgit2_opts(int key, ...)
git_smart__ofs_delta_enabled = (va_arg(ap, int) != 0); git_smart__ofs_delta_enabled = (va_arg(ap, int) != 0);
break; break;
case GIT_OPT_ENABLE_SYNCHRONIZED_OBJECT_CREATION:
git_object__synchronized_writing = (va_arg(ap, int) != 0);
break;
default: default:
giterr_set(GITERR_INVALID, "invalid option key"); giterr_set(GITERR_INVALID, "invalid option key");
error = -1; error = -1;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment