Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
git2
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
lvzhengyang
git2
Commits
5a0659fe
Commit
5a0659fe
authored
Aug 17, 2011
by
schu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
config_file.c: fix memory leaks
Signed-off-by: schu <schu-github@schulog.org>
parent
b6817692
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
5 deletions
+14
-5
src/config_file.c
+14
-5
No files found.
src/config_file.c
View file @
5a0659fe
...
...
@@ -212,8 +212,10 @@ static int cvar_normalize_name(cvar_t *var, char **output)
/* If there aren't any spaces in the section, it's easy */
if
(
section_sp
==
NULL
)
{
ret
=
snprintf
(
name
,
len
+
1
,
"%s.%s"
,
var
->
section
,
var
->
name
);
if
(
ret
<
0
)
if
(
ret
<
0
)
{
free
(
name
);
return
git__throw
(
GIT_EOSERR
,
"Failed to normalize name. OS err: %s"
,
strerror
(
errno
));
}
*
output
=
name
;
return
GIT_SUCCESS
;
...
...
@@ -701,12 +703,16 @@ static int parse_section_header(diskfile_backend *cfg, char **section_out)
/* find the end of the variable's name */
name_end
=
strchr
(
line
,
']'
);
if
(
name_end
==
NULL
)
if
(
name_end
==
NULL
)
{
free
(
line
);
return
git__throw
(
GIT_EOBJCORRUPTED
,
"Failed to parse header. Can't find header name end"
);
}
name
=
(
char
*
)
git__malloc
((
size_t
)(
name_end
-
line
)
+
1
);
if
(
name
==
NULL
)
if
(
name
==
NULL
)
{
free
(
line
);
return
GIT_ENOMEM
;
}
name_length
=
0
;
pos
=
0
;
...
...
@@ -738,8 +744,10 @@ static int parse_section_header(diskfile_backend *cfg, char **section_out)
}
while
((
c
=
line
[
pos
++
])
!=
']'
);
if
(
line
[
pos
-
1
]
!=
']'
)
return
git__throw
(
GIT_EOBJCORRUPTED
,
"Failed to parse header. Config file ended unexpectedly"
);
if
(
line
[
pos
-
1
]
!=
']'
)
{
error
=
git__throw
(
GIT_EOBJCORRUPTED
,
"Failed to parse header. Config file ended unexpectedly"
);
goto
error
;
}
name
[
name_length
]
=
0
;
free
(
line
);
...
...
@@ -957,6 +965,7 @@ static int config_write(diskfile_backend *cfg, cvar_t *var)
* default case will take care of updating them.
*/
pre_end
=
post_start
=
cfg
->
reader
.
read_ptr
;
if
(
current_section
)
free
(
current_section
);
error
=
parse_section_header
(
cfg
,
&
current_section
);
if
(
error
<
GIT_SUCCESS
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment