Skip to content

G
git2
Commit 56c1cda2 by Ben Straub
Options

Clarify parsing issues and errors

parent 7e035908
Showing with 3 additions and 2 deletions
src/netops.c
...@@ -674,7 +674,8 @@ int gitno_extract_url_parts( ...@@ -674,7 +674,8 @@ int gitno_extract_url_parts(
* ==> [user[:pass]@]hostname.tld[:port]/resource * ==> [user[:pass]@]hostname.tld[:port]/resource
*/ */
/* Check for user and maybe password */ /* Check for user and maybe password. Note that this deviates from RFC-1738
* in that it allows non-encoded colons in the password field. */
at = strchr(url, '@'); at = strchr(url, '@');
if (at) { if (at) {
colon = strchr(url, ':'); colon = strchr(url, ':');
...@@ -695,7 +696,7 @@ int gitno_extract_url_parts( ...@@ -695,7 +696,7 @@ int gitno_extract_url_parts(
colon = strchr(url, ':'); colon = strchr(url, ':');
if (!slash || if (!slash ||
(colon && (slash < colon))) { (colon && (slash < colon))) {
giterr_set(GITERR_NET, "Malformed URL"); giterr_set(GITERR_NET, "Malformed URL: %s", url);
return GIT_EINVALIDSPEC; return GIT_EINVALIDSPEC;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment