Commit 35b7bca2 by Patrick Steinhardt

tests: transport: fix memory leaks with registering transports

parent e756877d
...@@ -40,20 +40,23 @@ void test_transport_register__custom_transport_error_remove_non_existing(void) ...@@ -40,20 +40,23 @@ void test_transport_register__custom_transport_error_remove_non_existing(void)
void test_transport_register__custom_transport_ssh(void) void test_transport_register__custom_transport_ssh(void)
{ {
const char *urls[] = {
"ssh://somehost:somepath",
"ssh+git://somehost:somepath",
"git+ssh://somehost:somepath",
"git@somehost:somepath",
};
git_transport *transport; git_transport *transport;
unsigned i;
for (i = 0; i < ARRAY_SIZE(urls); i++) {
#ifndef GIT_SSH #ifndef GIT_SSH
cl_git_fail_with(git_transport_new(&transport, NULL, "ssh://somehost:somepath"), -1); cl_git_fail_with(git_transport_new(&transport, NULL, urls[i]), -1);
cl_git_fail_with(git_transport_new(&transport, NULL, "ssh+git://somehost:somepath"), -1);
cl_git_fail_with(git_transport_new(&transport, NULL, "git+ssh://somehost:somepath"), -1);
cl_git_fail_with(git_transport_new(&transport, NULL, "git@somehost:somepath"), -1);
#else #else
cl_git_pass(git_transport_new(&transport, NULL, "ssh://somehost:somepath")); cl_git_pass(git_transport_new(&transport, NULL, urls[i]));
cl_git_pass(git_transport_new(&transport, NULL, "ssh+git://somehost:somepath"));
cl_git_pass(git_transport_new(&transport, NULL, "git+ssh://somehost:somepath"));
cl_git_pass(git_transport_new(&transport, NULL, "git@somehost:somepath"));
transport->free(transport); transport->free(transport);
#endif #endif
}
cl_git_pass(git_transport_register("ssh", dummy_transport, NULL)); cl_git_pass(git_transport_register("ssh", dummy_transport, NULL));
...@@ -63,16 +66,12 @@ void test_transport_register__custom_transport_ssh(void) ...@@ -63,16 +66,12 @@ void test_transport_register__custom_transport_ssh(void)
cl_git_pass(git_transport_unregister("ssh")); cl_git_pass(git_transport_unregister("ssh"));
for (i = 0; i < ARRAY_SIZE(urls); i++) {
#ifndef GIT_SSH #ifndef GIT_SSH
cl_git_fail_with(git_transport_new(&transport, NULL, "ssh://somehost:somepath"), -1); cl_git_fail_with(git_transport_new(&transport, NULL, urls[i]), -1);
cl_git_fail_with(git_transport_new(&transport, NULL, "ssh+git://somehost:somepath"), -1);
cl_git_fail_with(git_transport_new(&transport, NULL, "git+ssh://somehost:somepath"), -1);
cl_git_fail_with(git_transport_new(&transport, NULL, "git@somehost:somepath"), -1);
#else #else
cl_git_pass(git_transport_new(&transport, NULL, "ssh://somehost:somepath")); cl_git_pass(git_transport_new(&transport, NULL, urls[i]));
cl_git_pass(git_transport_new(&transport, NULL, "ssh+git://somehost:somepath"));
cl_git_pass(git_transport_new(&transport, NULL, "git+ssh://somehost:somepath"));
cl_git_pass(git_transport_new(&transport, NULL, "git@somehost:somepath"));
transport->free(transport); transport->free(transport);
#endif #endif
}
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment