Prevent segfault with a badly-formed URL

151b3218 · Ben Straub · 7be5104d · 151b3218
Commit 151b3218 authored Oct 31, 2013 by Ben Straub
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

src/netops.c
+4 -3

No files found.
--- a/src/netops.c
+++ b/src/netops.c
@@ -679,9 +679,10 @@ int gitno_extract_url_parts(
 	slash = strchr(url, '/');
 	at = strchr(url, '@');

-	if (slash == NULL) {
-		giterr_set(GITERR_NET, "Malformed URL: missing /");
-		return -1;
+	if (!slash ||
+	    (colon && slash < colon)) {
+		giterr_set(GITERR_NET, "Malformed URL");
+		return GIT_EINVALIDSPEC;
 	}

 	start = url;